Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support non-broadcasting (non-scalar) assignment on list columns #13291

Open
wence- opened this issue May 4, 2023 · 2 comments
Open

[FEA] Support non-broadcasting (non-scalar) assignment on list columns #13291

wence- opened this issue May 4, 2023 · 2 comments
Assignees
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request Python Affects Python cuDF API.

Comments

@wence-
Copy link
Contributor

wence- commented May 4, 2023

Consider

import cudf

s = cudf.Series([[1], [2], [3]])
g = cudf.Series([[4], [5]])

s.iloc[:2] = g

I would expect this to work and produce [[4], [5], [3]]. Instead, we get an error:

ValueError: Can not set <cudf.core.column.lists.ListColumn object at 0x7fea4b0f5cc0>
[
  [
    4
  ],
  [
    5
  ]
]
dtype: list into ListColumn

Indeed, the only things we can __setitem__ into list columns are cudf.NA and a singleton list (treated as a cudf.Scalar) that is broadcast to all entries.

@wence- wence- added feature request New feature or request Needs Triage Need team to review and classify labels May 4, 2023
@wence- wence- self-assigned this May 4, 2023
@GregoryKimball
Copy link
Contributor

Is this topic covered by another issue in #12793?

@GregoryKimball GregoryKimball added 0 - Backlog In queue waiting for assignment Python Affects Python cuDF API. and removed Needs Triage Need team to review and classify labels Jun 7, 2023
@wence-
Copy link
Contributor Author

wence- commented Jun 7, 2023

Maybe related to #11944 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - Backlog In queue waiting for assignment feature request New feature or request Python Affects Python cuDF API.
Projects
Status: Todo
Development

No branches or pull requests

2 participants