Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH]: cudf options that map onto pandas ones should have identical names #12765

Open
wence- opened this issue Feb 13, 2023 · 1 comment
Open

[ENH]: cudf options that map onto pandas ones should have identical names #12765

wence- opened this issue Feb 13, 2023 · 1 comment
Assignees
@wence-
Labels
Python Affects Python cuDF API.

Comments

@wence-
Copy link
Contributor

wence- commented Feb 13, 2023

A followup to #12619; to enable copy-on-write in pandas one says set_option("mode.copy_on_write", True), whereas to enable in cudf one must say set_option("copy_on_write", True).

There might be other cases, but where cudf exposes the same configuration options as pandas, the names should match as a principle of least surprise.
@wence- wence- self-assigned this Feb 13, 2023
@wence- wence- added pandas Python Affects Python cuDF API. labels Feb 13, 2023
@wence- wence- mentioned this issue Feb 13, 2023
Merged
5 tasks
@wence-
Copy link
Contributor Author

wence- commented Feb 17, 2023

Copy-on-write looks to be the only matching option right now. Matching the intricacies of the pandas system is actually somewhat more complicated than just renaming, since they implement the nested dictionaries as attribute access on the the pd.options module.

@vyasr vyasr removed the pandas label May 16, 2024
@vyasr vyasr added this to cuDF Python Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wence- wence-

Labels
Python Affects Python cuDF API.
Projects
cuDF Python
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wence- @vyasr