Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Cleanup of unneeded functions in Python aggregation types. #10394

Open
nvdbaranec opened this issue Mar 7, 2022 · 2 comments
Open

[FEA] Cleanup of unneeded functions in Python aggregation types. #10394

nvdbaranec opened this issue Mar 7, 2022 · 2 comments
Assignees
@nvdbaranec
Labels
good first issue Good for newcomers Python Affects Python cuDF API.

Comments

@nvdbaranec
Copy link
Contributor

With this PR #10357 all aggregations in cudf are now represented as algorithm-specific aggregation classes. There is some followup cleanup work to be done in the python bindings. See:

#10357 (comment)
@nvdbaranec nvdbaranec added feature request New feature or request Needs Triage Need team to review and classify Python Affects Python cuDF API. labels Mar 7, 2022
@nvdbaranec nvdbaranec self-assigned this Mar 7, 2022
@nvdbaranec nvdbaranec mentioned this issue Mar 7, 2022
Merged
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@GregoryKimball GregoryKimball added tech debt good first issue Good for newcomers and removed Needs Triage Need team to review and classify feature request New feature or request labels Jun 28, 2022
@vyasr
Copy link
Contributor

vyasr commented Jul 15, 2022

@karthikeyann how do you anticipate resolving this? The user will still request these aggregations using names like cumsum and cummax. Did you want to remove the prefix before trying to access the attribute from the relevant aggregation class?

@vyasr vyasr removed the tech debt label Feb 23, 2024
@vyasr vyasr added this to cuDF Python Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvdbaranec nvdbaranec

Labels
good first issue Good for newcomers Python Affects Python cuDF API.
Projects
cuDF Python
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vyasr @GregoryKimball @nvdbaranec