Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add File Statistic when writing the ORC file #10075

Closed
wbo4958 opened this issue Jan 19, 2022 · 4 comments
Closed

[FEA] Add File Statistic when writing the ORC file #10075

wbo4958 opened this issue Jan 19, 2022 · 4 comments
Labels
cuIO cuIO issue feature request New feature or request

Comments

@wbo4958
Copy link
Contributor

wbo4958 commented Jan 19, 2022

Even with #10041 adding Statistic in RowIndex, CUDF still does not support writing the whole File Statistics into the ORC file.

Why do we need this FEA?

Spark added a new FEA about aggregate pushdown for ORC/Parquet file format as of Spark 3.3.0, which pushes the aggregate to DataSource to calculate the aggregation.

Typically, for ORC, it will read File Statistics from the ORC file and get the column stats and finally do the aggregate(max/min/count) without reading any real data of the ORC file. which can remarkably improve the performance.

But if there is no File Statistic in the ORC file, Spark will throw an exception.

@wbo4958 wbo4958 added feature request New feature or request Needs Triage Need team to review and classify and removed feature request New feature or request labels Jan 19, 2022
@wbo4958 wbo4958 added the feature request New feature or request label Jan 19, 2022
@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@amahussein
Copy link

There is a standing bug #5826 that points to missing statistics for chunk mode.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@vuule
Copy link
Contributor

vuule commented Jun 8, 2022

@wbo4958 I think the issue should be fixed by #10694
Is anything else pending here?

@vuule vuule added the cuIO cuIO issue label Jun 8, 2022
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuIO cuIO issue feature request New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants