Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Performance Updates for row/column conversions #10032

Closed
5 tasks done
hyperbolic2346 opened this issue Jan 13, 2022 · 5 comments
Closed
5 tasks done

[FEA] Performance Updates for row/column conversions #10032

hyperbolic2346 opened this issue Jan 13, 2022 · 5 comments
Labels
feature request New feature or request Java Affects Java cuDF API.

Comments

@hyperbolic2346
Copy link
Contributor

hyperbolic2346 commented Jan 13, 2022

The row/column conversion code isn't as performance as desired. This is a list of things that should be tried to attempt to improve the performance.

  • Different tile sizes. Right now the tile is square in size, but this may not be the best option. Tall and wide tiles should be investigated.
  • Uncoalesced memory access is called out in nsight traces. Investigation into the source of these accesses is needed.
  • It was suggested in the review of Rewriting row/column conversions for Spark <-> cudf data conversions #8444 that it might make more sense for a block to not consume the entire shared memory available in an attempt to allow more blocks to run concurrently in order to hide the memory latency.
  • Investigate tile ordering
  • Investigate thread stride changes to improve throughput
@hyperbolic2346 hyperbolic2346 added feature request New feature or request Needs Triage Need team to review and classify labels Jan 13, 2022
@hyperbolic2346
Copy link
Contributor Author

Tile sizes of 1 column, 1 row, 32 columns, and 32 rows were tried with little to no performance gain. Most saw a loss of performance.

@hyperbolic2346
Copy link
Contributor Author

Changed shared memory sizes to 1/2, 1/4, and 1/16 of the available memory and performance was the same for column to row and degraded for row to column.

@github-actions
Copy link

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@hyperbolic2346
Copy link
Contributor Author

Still relevant

@GregoryKimball GregoryKimball added Java Affects Java cuDF API. and removed Needs Triage Need team to review and classify labels Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request Java Affects Java cuDF API.
Projects
None yet
Development

No branches or pull requests

2 participants