From f36e3bc308268e4ac483ac02b8674a5cde71e5b2 Mon Sep 17 00:00:00 2001 From: Lawrence Mitchell Date: Thu, 11 Jul 2024 07:51:01 +0000 Subject: [PATCH] Remove detail/public split and nvtx range --- cpp/include/cudf/detail/unary.hpp | 5 ----- cpp/src/unary/cast_ops.cu | 10 +++------- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/cpp/include/cudf/detail/unary.hpp b/cpp/include/cudf/detail/unary.hpp index 31111bec113..5245cfdf079 100644 --- a/cpp/include/cudf/detail/unary.hpp +++ b/cpp/include/cudf/detail/unary.hpp @@ -86,11 +86,6 @@ std::unique_ptr cast(column_view const& input, rmm::cuda_stream_view stream, rmm::device_async_resource_ref mr); -/** - * @copydoc cudf::is_supported_cast - */ -bool is_supported_cast(data_type from, data_type to) noexcept; - /** * @copydoc cudf::is_nan */ diff --git a/cpp/src/unary/cast_ops.cu b/cpp/src/unary/cast_ops.cu index 0ddf805a260..ec21813705a 100644 --- a/cpp/src/unary/cast_ops.cu +++ b/cpp/src/unary/cast_ops.cu @@ -468,11 +468,6 @@ struct is_supported_cast_impl { } }; -bool is_supported_cast(data_type from, data_type to) noexcept -{ - return double_type_dispatcher(from, to, is_supported_cast_impl{}); -} - } // namespace detail std::unique_ptr cast(column_view const& input, @@ -486,8 +481,9 @@ std::unique_ptr cast(column_view const& input, bool is_supported_cast(data_type from, data_type to) noexcept { - CUDF_FUNC_RANGE(); - return detail::is_supported_cast(from, to); + // No matching detail API call/nvtx annotation, since this doesn't + // launch a kernel. + return double_type_dispatcher(from, to, detail::is_supported_cast_impl{}); } } // namespace cudf