From eaae68d8b099e90a2e3bcc968f98c652d36bb844 Mon Sep 17 00:00:00 2001 From: Bradley Dice Date: Wed, 17 Apr 2024 18:33:41 -0500 Subject: [PATCH] Deprecate legacy JSON reader options. (#15558) This PR deprecates the option for using the legacy JSON reader, so it can be removed in the next RAPIDS release. This work follows up on a task from https://github.com/rapidsai/cudf/issues/15537 Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Muhammad Haseeb (https://github.com/mhaseeb123) - Vukasin Milovanovic (https://github.com/vuule) URL: https://github.com/rapidsai/cudf/pull/15558 --- cpp/include/cudf/io/json.hpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/cpp/include/cudf/io/json.hpp b/cpp/include/cudf/io/json.hpp index d8330b78f0e..a6112b8db4c 100644 --- a/cpp/include/cudf/io/json.hpp +++ b/cpp/include/cudf/io/json.hpp @@ -251,9 +251,11 @@ class json_reader_options { /** * @brief Whether the legacy reader should be used. * + * @deprecated Since 24.06 + * * @returns true if the legacy reader will be used, false otherwise */ - bool is_enabled_legacy() const { return _legacy; } + [[deprecated]] bool is_enabled_legacy() const { return _legacy; } /** * @brief Whether the reader should keep quotes of string values. @@ -350,9 +352,11 @@ class json_reader_options { /** * @brief Set whether to use the legacy reader. * + * @deprecated Since 24.06 + * * @param val Boolean value to enable/disable the legacy reader */ - void enable_legacy(bool val) { _legacy = val; } + [[deprecated]] void enable_legacy(bool val) { _legacy = val; } /** * @brief Set whether the reader should keep quotes of string values. @@ -519,10 +523,12 @@ class json_reader_options_builder { /** * @brief Set whether to use the legacy reader. * + * @deprecated Since 24.06 + * * @param val Boolean value to enable/disable legacy parsing * @return this for chaining */ - json_reader_options_builder& legacy(bool val) + [[deprecated]] json_reader_options_builder& legacy(bool val) { options._legacy = val; return *this;