From dfaa41c28e27f54500cf41e91958528c8f883319 Mon Sep 17 00:00:00 2001 From: Kyle Edwards Date: Mon, 11 Mar 2024 15:01:44 -0400 Subject: [PATCH] Make linking of nvtx3-cpp BUILD_LOCAL_INTERFACE (#15271) When building as static libraries, CMake tries to export the PRIVATE nvtx3-cpp dependency due to how it handles static library exports. Since nvtx3-cpp is a header-only library, and since cudf's public headers don't depend on it, make it BUILD_LOCAL_INTERFACE to avoid exporting the nvtx3-cpp dependency. Issue: https://github.com/rapidsai/cudf/issues/15270 Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - Bradley Dice (https://github.com/bdice) - Nghia Truong (https://github.com/ttnghia) - Robert Maynard (https://github.com/robertmaynard) URL: https://github.com/rapidsai/cudf/pull/15271 --- cpp/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 47e9eb99733..5ccc2e76101 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -779,7 +779,7 @@ add_dependencies(cudf jitify_preprocess_run) target_link_libraries( cudf PUBLIC ${ARROW_LIBRARIES} CCCL::CCCL rmm::rmm - PRIVATE nvtx3-cpp cuco::cuco ZLIB::ZLIB nvcomp::nvcomp kvikio::kvikio + PRIVATE $ cuco::cuco ZLIB::ZLIB nvcomp::nvcomp kvikio::kvikio $ )