From cfac5b91522b8de1937c9e733719a599f8c75e83 Mon Sep 17 00:00:00 2001 From: galipremsagar Date: Tue, 7 Sep 2021 11:30:47 -0500 Subject: [PATCH] address reviews --- python/cudf/cudf/tests/test_dataframe.py | 3 +-- python/cudf/cudf/tests/test_index.py | 9 +++------ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/python/cudf/cudf/tests/test_dataframe.py b/python/cudf/cudf/tests/test_dataframe.py index c065d7c2e18..62026287d83 100644 --- a/python/cudf/cudf/tests/test_dataframe.py +++ b/python/cudf/cudf/tests/test_dataframe.py @@ -1241,8 +1241,7 @@ def test_dataframe_concat_different_numerical_columns(dtype1, dtype2): else: pres = pd.concat([df1, df2]) gres = cudf.concat([cudf.from_pandas(df1), cudf.from_pandas(df2)]) - # Pandas 1.3.2+ returns mixed `object` dtype result. - assert_eq(cudf.from_pandas(pres.astype(gres.dtypes)), gres) + assert_eq(pres, gres, check_dtype=False) def test_dataframe_concat_different_column_types(): diff --git a/python/cudf/cudf/tests/test_index.py b/python/cudf/cudf/tests/test_index.py index d64267b149d..a3de92ba9e5 100644 --- a/python/cudf/cudf/tests/test_index.py +++ b/python/cudf/cudf/tests/test_index.py @@ -1873,12 +1873,9 @@ def test_index_fillna(data, fill_value): pdi = pd.Index(data) gdi = cudf.Index(data) - if isinstance(gdi, cudf.Int64Index) and isinstance(pdi, pd.Float64Index): - assert_eq( - pdi.fillna(fill_value).astype(gdi.dtype), gdi.fillna(fill_value) - ) - else: - assert_eq(pdi.fillna(fill_value), gdi.fillna(fill_value)) + assert_eq( + pdi.fillna(fill_value), gdi.fillna(fill_value), exact=False + ) # Int64Index v/s Float64Index @pytest.mark.parametrize(