From b47f5ee7d76e2382906adc351caff91b13801843 Mon Sep 17 00:00:00 2001 From: Mark Harris <783069+harrism@users.noreply.github.com> Date: Sat, 27 Jan 2024 09:21:17 +1100 Subject: [PATCH] Remove supports_streams from cuDF custom memory resources. (#14857) Part of https://github.com/rapidsai/rmm/issues/1389. This removes now-optional and soon-to-be deprecated `supports_streams()` from cuDF's custom `device_memory_resource` implementations. Depends on https://github.com/rapidsai/rmm/pull/1437 Authors: - Mark Harris (https://github.com/harrism) - Bradley Dice (https://github.com/bdice) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) - Yunsong Wang (https://github.com/PointKernel) - Michael Schellenberger Costa (https://github.com/miscco) URL: https://github.com/rapidsai/cudf/pull/14857 --- cpp/include/cudf_test/stream_checking_resource_adaptor.hpp | 7 ------- java/src/main/native/src/RmmJni.cpp | 4 ---- 2 files changed, 11 deletions(-) diff --git a/cpp/include/cudf_test/stream_checking_resource_adaptor.hpp b/cpp/include/cudf_test/stream_checking_resource_adaptor.hpp index 90a8c2ccc2f..d1841ff42a1 100644 --- a/cpp/include/cudf_test/stream_checking_resource_adaptor.hpp +++ b/cpp/include/cudf_test/stream_checking_resource_adaptor.hpp @@ -64,13 +64,6 @@ class stream_checking_resource_adaptor final : public rmm::mr::device_memory_res */ Upstream* get_upstream() const noexcept { return upstream_; } - /** - * @brief Checks whether the upstream resource supports streams. - * - * @return Whether or not the upstream resource supports streams - */ - bool supports_streams() const noexcept override { return upstream_->supports_streams(); } - private: /** * @brief Allocates memory of size at least `bytes` using the upstream diff --git a/java/src/main/native/src/RmmJni.cpp b/java/src/main/native/src/RmmJni.cpp index b92d9e4e891..81b8241bab0 100644 --- a/java/src/main/native/src/RmmJni.cpp +++ b/java/src/main/native/src/RmmJni.cpp @@ -96,8 +96,6 @@ class tracking_resource_adaptor final : public base_tracking_resource_adaptor { return scoped_max_total_allocated; } - bool supports_streams() const noexcept override { return resource->supports_streams(); } - private: Upstream *const resource; std::size_t const size_align; @@ -207,8 +205,6 @@ class java_event_handler_memory_resource : public device_memory_resource { device_memory_resource *get_wrapped_resource() { return resource; } - bool supports_streams() const noexcept override { return resource->supports_streams(); } - private: device_memory_resource *const resource; base_tracking_resource_adaptor *const tracker;