From b250ac70a77b94c119ce252d97e3e3b698addb17 Mon Sep 17 00:00:00 2001 From: Bradley Dice Date: Wed, 22 Jun 2022 09:20:48 -0500 Subject: [PATCH] Clean up repo root (#11124) This PR removes the outdated files `.dockerignore` and `MANIFEST.in`. The Dockerfile was removed in #10069 so we don't need to keep the ignore file around anymore. The `MANIFEST.in` is very old (last updated in 2018, cad899bb9516c173e4b07bd48e8e7b5e10ca412d) and no longer correct for the current package structure. Finally, I moved `.clang-tidy` into the `cpp/` directory. @codereport said that would be fine to clean up from the root and have no negative effects since clang-tidy isn't being run yet. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Karthikeyan (https://github.com/karthikeyann) - AJ Schmidt (https://github.com/ajschmidt8) URL: https://github.com/rapidsai/cudf/pull/11124 --- .dockerignore | 2 -- .github/CODEOWNERS | 3 --- MANIFEST.in | 2 -- .clang-tidy => cpp/.clang-tidy | 4 ++-- 4 files changed, 2 insertions(+), 9 deletions(-) delete mode 100644 .dockerignore delete mode 100644 MANIFEST.in rename .clang-tidy => cpp/.clang-tidy (97%) diff --git a/.dockerignore b/.dockerignore deleted file mode 100644 index fa91e436343..00000000000 --- a/.dockerignore +++ /dev/null @@ -1,2 +0,0 @@ -# Ignore cmake builds from local machine that might have occurred before attempting Docker build. Including these files will cause CMake cache conflict issues -/cpp/build diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 573fecca003..b2d2755e9e0 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -18,6 +18,3 @@ java/ @rapidsai/cudf-java-codeowners .github/ @rapidsai/ops-codeowners /ci/ @rapidsai/ops-codeowners conda/ @rapidsai/ops-codeowners -/Dockerfile @rapidsai/ops-codeowners -/.dockerignore @rapidsai/ops-codeowners -/docker/ @rapidsai/ops-codeowners diff --git a/MANIFEST.in b/MANIFEST.in deleted file mode 100644 index 57f31cf3a80..00000000000 --- a/MANIFEST.in +++ /dev/null @@ -1,2 +0,0 @@ -include python/versioneer.py -include python/cudf/_version.py diff --git a/.clang-tidy b/cpp/.clang-tidy similarity index 97% rename from .clang-tidy rename to cpp/.clang-tidy index 043a93e6ff9..d766d98b45e 100644 --- a/.clang-tidy +++ b/cpp/.clang-tidy @@ -1,10 +1,10 @@ --- -Checks: +Checks: 'modernize-*, -modernize-use-equals-default, -modernize-concat-nested-namespaces, -modernize-use-trailing-return-type' - + # -modernize-use-equals-default # auto-fix is broken (doesn't insert =default correctly) # -modernize-concat-nested-namespaces # auto-fix is broken (can delete code) # -modernize-use-trailing-return-type # just a preference