From ad5265d007445c0d6c28209b0994f9be165f681c Mon Sep 17 00:00:00 2001 From: Vyas Ramasubramani Date: Mon, 18 Dec 2023 22:32:27 +0000 Subject: [PATCH] Remove invalid test using a column with unsanitized nulls --- .../copying/segmented_gather_list_tests.cpp | 21 ------------------- 1 file changed, 21 deletions(-) diff --git a/cpp/tests/copying/segmented_gather_list_tests.cpp b/cpp/tests/copying/segmented_gather_list_tests.cpp index dda54cb5289..8881fb344a2 100644 --- a/cpp/tests/copying/segmented_gather_list_tests.cpp +++ b/cpp/tests/copying/segmented_gather_list_tests.cpp @@ -301,27 +301,6 @@ TYPED_TEST(SegmentedGatherTest, GatherNegatives) } } -TYPED_TEST(SegmentedGatherTest, GatherOnNonCompactedNullLists) -{ - using T = TypeParam; - auto constexpr X = -1; // Signifies null value. - - // List - auto list = LCW{{{1, 2, 3, 4}, {5}, {6, 7}, {8, 9, 0}, {}, {1, 2}, {3, 4, 5}}, no_nulls()}; - auto const input = list.release(); - - // Set non-empty list row at index 5 to null. - cudf::detail::set_null_mask( - input->mutable_view().null_mask(), 5, 6, false, cudf::get_default_stream()); - - auto const gather_map = LCW{{-1, 2, 1, -4}, {0}, {-2, 1}, {0, 2, 1}, {}, {0}, {1, 2}}; - auto const expected = - LCW{{{4, 3, 2, 1}, {5}, {6, 7}, {8, 0, 9}, {}, {{X}, all_nulls()}, {4, 5}}, null_at(5)}; - auto const results = cudf::lists::segmented_gather(cudf::lists_column_view{*input}, - cudf::lists_column_view{gather_map}); - CUDF_TEST_EXPECT_COLUMNS_EQUIVALENT(results->view(), expected); -} - TYPED_TEST(SegmentedGatherTest, GatherNestedNulls) { using T = TypeParam;