From 91d412b63338637e11074028d50e2891d31ff81b Mon Sep 17 00:00:00 2001 From: Robert Maynard Date: Fri, 17 Sep 2021 08:32:46 -0400 Subject: [PATCH] Remove zlib from libcudf public CMake dependencies (#9204) libcudf doesn't expose zlib in the public facing API, and therefore C++ consumers don't need to also link / include zlib. Authors: - Robert Maynard (https://github.com/robertmaynard) - Keith Kraus (https://github.com/kkraus14) Approvers: - Keith Kraus (https://github.com/kkraus14) - Mark Harris (https://github.com/harrism) URL: https://github.com/rapidsai/cudf/pull/9204 --- cpp/CMakeLists.txt | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 079db9d144b..c72c258fd18 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -102,9 +102,8 @@ include(cmake/Modules/ConfigureCUDA.cmake) # set other CUDA compilation flags # - dependencies ---------------------------------------------------------------------------------- # find zlib -rapids_find_package(ZLIB REQUIRED - BUILD_EXPORT_SET cudf-exports - INSTALL_EXPORT_SET cudf-exports) +rapids_find_package(ZLIB REQUIRED) + # find Threads (needed by cudftestutil) rapids_find_package(Threads REQUIRED BUILD_EXPORT_SET cudf-exports @@ -506,11 +505,11 @@ add_dependencies(cudf jitify_preprocess_run) # Specify the target module library dependencies target_link_libraries(cudf - PUBLIC ZLIB::ZLIB - ${ARROW_LIBRARIES} + PUBLIC ${ARROW_LIBRARIES} cudf::Thrust rmm::rmm PRIVATE cuco::cuco + ZLIB::ZLIB nvcomp::nvcomp) # Add Conda library, and include paths if specified