From b828e6cea776c17ec73572403e7a87edc3d1a721 Mon Sep 17 00:00:00 2001 From: Jake Hemstad Date: Tue, 17 Mar 2020 14:26:39 -0500 Subject: [PATCH 1/3] Add CMake option to disable deprecation warnings --- cpp/CMakeLists.txt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index f3ab25bd243..5e2c2bd98ec 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -112,6 +112,12 @@ set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} --expt-extended-lambda --expt-relaxed- # TODO: remove `no-maybe-unitialized` used to suppress warnings in rmm::exec_policy set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -Werror cross-execution-space-call -Xcompiler -Wall,-Werror,-Wno-error=deprecated-declarations") +option(DISABLE_DEPRACATION_WARNING "Disable warnings generated from deprecated declarations." OFF) +if(DISABLE_DEPRACATION_WARNING) + set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -Xcompiler -Wno-deprecated-declarations") + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-declarations") +endif(DISABLE_DEPRACATION_WARNING) + # Option to enable line info in CUDA device compilation to allow introspection when profiling / memchecking option(CMAKE_CUDA_LINEINFO "Enable the -lineinfo option for nvcc (useful for cuda-memcheck / profiler" OFF) if(CMAKE_CUDA_LINEINFO) From 4e66781b1b62190deeb746da11c9dc46a7581fdf Mon Sep 17 00:00:00 2001 From: Jake Hemstad Date: Tue, 17 Mar 2020 14:28:57 -0500 Subject: [PATCH 2/3] Changelog. --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2c7cafc2d35..ae000682cac 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -175,6 +175,7 @@ - PR #4524 Updating `__setitem__` for DataFrame to use scalar scatter - PR #4534 Disable deprecation warnings as errors. - PR #4506 Check for multi-dimensional data in column/Series creation +- PR #4549 Add option to disable deprecation warnings. ## Bug Fixes From fa08a3015402d8b94bbd33eb854405d6eebbecfd Mon Sep 17 00:00:00 2001 From: Jake Hemstad Date: Tue, 17 Mar 2020 14:50:02 -0500 Subject: [PATCH 3/3] Update cpp/CMakeLists.txt Co-Authored-By: Keith Kraus --- cpp/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt index 5e2c2bd98ec..694c9aad9f9 100644 --- a/cpp/CMakeLists.txt +++ b/cpp/CMakeLists.txt @@ -112,11 +112,11 @@ set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} --expt-extended-lambda --expt-relaxed- # TODO: remove `no-maybe-unitialized` used to suppress warnings in rmm::exec_policy set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -Werror cross-execution-space-call -Xcompiler -Wall,-Werror,-Wno-error=deprecated-declarations") -option(DISABLE_DEPRACATION_WARNING "Disable warnings generated from deprecated declarations." OFF) -if(DISABLE_DEPRACATION_WARNING) +option(DISABLE_DEPRECATION_WARNING "Disable warnings generated from deprecated declarations." OFF) +if(DISABLE_DEPRECATION_WARNING) set(CMAKE_CUDA_FLAGS "${CMAKE_CUDA_FLAGS} -Xcompiler -Wno-deprecated-declarations") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-declarations") -endif(DISABLE_DEPRACATION_WARNING) +endif(DISABLE_DEPRECATION_WARNING) # Option to enable line info in CUDA device compilation to allow introspection when profiling / memchecking option(CMAKE_CUDA_LINEINFO "Enable the -lineinfo option for nvcc (useful for cuda-memcheck / profiler" OFF)