From 7b45716e464c69152ed4d9c83c3f34c490430550 Mon Sep 17 00:00:00 2001 From: Karthikeyan Natarajan Date: Sat, 21 May 2022 20:29:57 +0530 Subject: [PATCH] address review comments (davidwendt) --- cpp/include/cudf/detail/copy_if_else.cuh | 2 +- cpp/include/cudf/types.hpp | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/cpp/include/cudf/detail/copy_if_else.cuh b/cpp/include/cudf/detail/copy_if_else.cuh index 233fbd1d601..b2710223693 100644 --- a/cpp/include/cudf/detail/copy_if_else.cuh +++ b/cpp/include/cudf/detail/copy_if_else.cuh @@ -51,7 +51,7 @@ __launch_bounds__(block_size) __global__ // begin/end indices for the column data size_type begin = 0; size_type end = out.size(); - // warp indices. since 1 warp == 32 threads == sizeof(bit_mask_t) * 8, + // warp indices. since 1 warp == 32 threads == sizeof(bitmask_type) * 8, // each warp will process one (32 bit) of the validity mask via // __ballot_sync() size_type warp_begin = cudf::word_index(begin); diff --git a/cpp/include/cudf/types.hpp b/cpp/include/cudf/types.hpp index 533ef83b175..88ac9e69c3d 100644 --- a/cpp/include/cudf/types.hpp +++ b/cpp/include/cudf/types.hpp @@ -32,13 +32,8 @@ * @brief Type declarations for libcudf. */ -// FIXME: where is this used? TODO: remove if unused. -namespace bit_mask { -using bit_mask_t = uint32_t; -} - // Forward declarations -/// @cond FORWARD_DECLARATIONS +/// @cond namespace rmm { class device_buffer; namespace mr { @@ -247,7 +242,7 @@ class data_type { data_type() = default; ~data_type() = default; data_type(data_type const&) = default; ///< Copy constructor - data_type(data_type&&) = default; ///< Move constructor + data_type(data_type&&) = default; ///< Move constructor /** * @brief Copy assignment operator for data_type