From 5c78b7ea6b75f503d5df4abc828d80a0b470a284 Mon Sep 17 00:00:00 2001 From: Lawrence Mitchell Date: Fri, 12 Jan 2024 08:49:20 +0000 Subject: [PATCH] Fix logic bug introduced in #14730 (#14742) The removal of `valid_count` on columns in #14730 had one logic bug, fixed here. Authors: - Lawrence Mitchell (https://github.com/wence-) Approvers: - Matthew Roeschke (https://github.com/mroeschke) - Vyas Ramasubramani (https://github.com/vyasr) URL: https://github.com/rapidsai/cudf/pull/14742 --- python/cudf/cudf/core/column/categorical.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/cudf/cudf/core/column/categorical.py b/python/cudf/cudf/core/column/categorical.py index f52621dc444..6b3ee0ba852 100644 --- a/python/cudf/cudf/core/column/categorical.py +++ b/python/cudf/cudf/core/column/categorical.py @@ -1380,7 +1380,7 @@ def _concat( # Find the first non-null column: head = next( - (obj for obj in objs if not obj.null_count != len(obj)), objs[0] + (obj for obj in objs if obj.null_count != len(obj)), objs[0] ) # Combine and de-dupe the categories