From 3fef7f76626c3bfd402c40f87906f17683c43db4 Mon Sep 17 00:00:00 2001 From: Alan deLevie Date: Thu, 4 Feb 2021 20:26:34 -0500 Subject: [PATCH] Fix typo in cudf.core.column.string.extract docs (#7253) change: on -> one I read the contributing guidelines, but since this is just a documentation fix, I'm not sure which apply. Great library, I just got started using it. A little rough around the edges, but great so far, and well worth some of the added steps. Authors: - Alan deLevie (@adelevie) - AJ Schmidt (@ajschmidt8) Approvers: - GALI PREM SAGAR (@galipremsagar) - Keith Kraus (@kkraus14) - Michael Wang (@isVoid) - Ray Douglass (@raydouglass) URL: https://github.com/rapidsai/cudf/pull/7253 --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- python/cudf/cudf/core/column/string.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6d16273bc26..ae895daf28a 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -39,9 +39,9 @@ Here are some guidelines to help the review process go smoothly. features or make changes out of the scope of those requested by the reviewer (doing this just add delays as already reviewed code ends up having to be re-reviewed/it is hard to tell what is new etc!). Further, please do not - rebase your branch on master/force push/rewrite history, doing any of these + rebase your branch on main/force push/rewrite history, doing any of these causes the context of any comments made by reviewers to be lost. If - conflicts occur against master they should be resolved by merging master + conflicts occur against main they should be resolved by merging main into the branch used for making the pull request. Many thanks in advance for your cooperation! diff --git a/python/cudf/cudf/core/column/string.py b/python/cudf/cudf/core/column/string.py index 7bdee346789..21f504ea684 100644 --- a/python/cudf/cudf/core/column/string.py +++ b/python/cudf/cudf/core/column/string.py @@ -486,7 +486,7 @@ def extract( pat : str Regular expression pattern with capturing groups. expand : bool, default True - If True, return DataFrame with on column per capture group. + If True, return DataFrame with one column per capture group. If False, return a Series/Index if there is one capture group or DataFrame if there are multiple capture groups.