From 50718e673ff53b18706cf66c6e02cda8e30681fe Mon Sep 17 00:00:00 2001 From: David Wendt <45795991+davidwendt@users.noreply.github.com> Date: Tue, 11 Apr 2023 15:19:02 -0400 Subject: [PATCH] Fix GPU_ARCHS setting in Java CMake build and CMAKE_CUDA_ARCHITECTURES in Python package build. (#13117) Changes the `GPU_ARCHS` setting in `pom.xml` from `ALL` to `RAPIDS` per recent change in rapidsai/rapids-cmake/pull/397 The Python package build requires CUDA as of the addition of string UDFs, which added compilation of ptx code to the Python build. Therefore CMAKE_CUDA_ARCHITECTURES must be set appropriately even when only the Python package is being built. https://github.com/rapidsai/rapids-cmake/pull/397 requires a nonempty string value to be used if the variable is set at all. This PR updates build.sh to include the appropriate default when only the Python build is requested. Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Robert (Bobby) Evans (https://github.com/revans2) - Bradley Dice (https://github.com/bdice) URL: https://github.com/rapidsai/cudf/pull/13117 --- build.sh | 2 +- java/pom.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/build.sh b/build.sh index 7cbd0fceb5a..5747ec169f4 100755 --- a/build.sh +++ b/build.sh @@ -257,7 +257,7 @@ fi ################################################################################ # Configure, build, and install libcudf -if buildAll || hasArg libcudf || hasArg cudfjar; then +if buildAll || hasArg libcudf || hasArg cudf || hasArg cudfjar; then if (( ${BUILD_ALL_GPU_ARCH} == 0 )); then CUDF_CMAKE_CUDA_ARCHITECTURES="${CUDF_CMAKE_CUDA_ARCHITECTURES:-NATIVE}" if [[ "$CUDF_CMAKE_CUDA_ARCHITECTURES" == "NATIVE" ]]; then diff --git a/java/pom.xml b/java/pom.xml index e259830695e..f644bed67fa 100644 --- a/java/pom.xml +++ b/java/pom.xml @@ -166,7 +166,7 @@ OFF OFF OFF - ALL + RAPIDS OFF ${project.build.directory}/cmake-build 1.7.30