From 429e296d0d66816c856f4ab6ca67d2f23fb5e6da Mon Sep 17 00:00:00 2001 From: Jason Lowe Date: Sat, 6 Mar 2021 07:57:29 -0600 Subject: [PATCH] Update JNI build to use CUDF_USE_ARROW_STATIC (#7526) This updates the Java build scripts and documentation to use the new CUDF_USE_ARROW_STATIC flag after the rename from ARROW_STATIC_LIB in #7518. Authors: - Jason Lowe (@jlowe) Approvers: - Alessandro Bellina (@abellina) - Keith Kraus (@kkraus14) URL: https://github.com/rapidsai/cudf/pull/7526 --- java/README.md | 2 +- java/ci/build-in-docker.sh | 4 ++-- java/src/main/native/CMakeLists.txt | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/java/README.md b/java/README.md index 421d6fa5e95..6ca58496605 100644 --- a/java/README.md +++ b/java/README.md @@ -67,7 +67,7 @@ cd boost_1_74_0 sudo cp stage/lib/libboost_filesystem.a /usr/local/lib/ ``` and pass in the cmake options -`-DARROW_STATIC_LIB=ON -DBoost_USE_STATIC_LIBS=ON` so that Apache Arrow and Boost libraries are +`-DCUDF_USE_ARROW_STATIC=ON -DBoost_USE_STATIC_LIBS=ON` so that Apache Arrow and Boost libraries are linked statically. If you use the default cmake options libcudart will be dynamically linked to libcudf diff --git a/java/ci/build-in-docker.sh b/java/ci/build-in-docker.sh index 964adf2f4e4..7e51a150ebc 100755 --- a/java/ci/build-in-docker.sh +++ b/java/ci/build-in-docker.sh @@ -1,7 +1,7 @@ #!/bin/bash # -# Copyright (c) 2020, NVIDIA CORPORATION. All rights reserved. +# Copyright (c) 2020-2021, NVIDIA CORPORATION. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -75,7 +75,7 @@ make -j$PARALLEL_LEVEL install rm -rf $WORKSPACE/cpp/build mkdir -p $WORKSPACE/cpp/build cd $WORKSPACE/cpp/build -cmake .. -DUSE_NVTX=OFF -DARROW_STATIC_LIB=ON -DBoost_USE_STATIC_LIBS=ON -DBUILD_TESTS=$SKIP_CPP_TESTS -DPER_THREAD_DEFAULT_STREAM=$ENABLE_PTDS -DRMM_LOGGING_LEVEL=$RMM_LOGGING_LEVEL +cmake .. -DUSE_NVTX=OFF -DCUDF_USE_ARROW_STATIC=ON -DBoost_USE_STATIC_LIBS=ON -DBUILD_TESTS=$SKIP_CPP_TESTS -DPER_THREAD_DEFAULT_STREAM=$ENABLE_PTDS -DRMM_LOGGING_LEVEL=$RMM_LOGGING_LEVEL make -j$PARALLEL_LEVEL make install DESTDIR=$INSTALL_PREFIX diff --git a/java/src/main/native/CMakeLists.txt b/java/src/main/native/CMakeLists.txt index 9d957e1ba9b..c1239fe69ea 100755 --- a/java/src/main/native/CMakeLists.txt +++ b/java/src/main/native/CMakeLists.txt @@ -175,7 +175,7 @@ find_library(ARROW_LIBRARY libarrow.a "${CUDF_CPP_BUILD_DIR}/_deps/arrow-build/release") if(NOT ARROW_LIBRARY) - message(FATAL_ERROR "Arrow static libs not found. Was libcudf built with ARROW_STATIC_LIB=ON?") + message(FATAL_ERROR "Arrow static libs not found. Was libcudf built with CUDF_USE_ARROW_STATIC=ON?") else() message(STATUS "ARROW: ARROW_LIBRARY set to ${ARROW_LIBRARY}") endif(NOT ARROW_LIBRARY)