From 1d58d5f4744e191af1044d66ff06a2c62b79ab5e Mon Sep 17 00:00:00 2001 From: Liangcai Li Date: Tue, 15 Aug 2023 12:26:10 +0800 Subject: [PATCH] Exclude some tests from running with the compute sanitizer (#13872) Authors: - Liangcai Li (https://github.com/firestarman) Approvers: - Robert (Bobby) Evans (https://github.com/revans2) - Jason Lowe (https://github.com/jlowe) URL: https://github.com/rapidsai/cudf/pull/13872 --- java/src/test/java/ai/rapids/cudf/CudaTest.java | 2 ++ java/src/test/java/ai/rapids/cudf/RmmTest.java | 13 ++++++++++++- java/src/test/java/ai/rapids/cudf/TableTest.java | 4 ++++ .../ai/rapids/cudf/UnsafeMemoryAccessorTest.java | 4 +++- 4 files changed, 21 insertions(+), 2 deletions(-) diff --git a/java/src/test/java/ai/rapids/cudf/CudaTest.java b/java/src/test/java/ai/rapids/cudf/CudaTest.java index e29bf1a672e..2edd7f36cb7 100644 --- a/java/src/test/java/ai/rapids/cudf/CudaTest.java +++ b/java/src/test/java/ai/rapids/cudf/CudaTest.java @@ -16,6 +16,7 @@ package ai.rapids.cudf; +import org.junit.jupiter.api.Tag; import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -33,6 +34,7 @@ public void testGetCudaRuntimeInfo() { assertEquals(Cuda.getNativeComputeMode(), Cuda.getComputeMode().nativeId); } + @Tag("noSanitizer") @Test public void testCudaException() { assertThrows(CudaException.class, () -> { diff --git a/java/src/test/java/ai/rapids/cudf/RmmTest.java b/java/src/test/java/ai/rapids/cudf/RmmTest.java index 352f17e6174..cd53cf7068a 100644 --- a/java/src/test/java/ai/rapids/cudf/RmmTest.java +++ b/java/src/test/java/ai/rapids/cudf/RmmTest.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 2020-2022, NVIDIA CORPORATION. + * Copyright (c) 2020-2023, NVIDIA CORPORATION. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -18,6 +18,7 @@ import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Tag; import org.junit.jupiter.api.Test; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.ValueSource; @@ -187,6 +188,7 @@ public void testScopedMaxOutstandingNegative(int rmmAllocMode) { } } + @Tag("noSanitizer") @ParameterizedTest @ValueSource(ints = { RmmAllocationMode.CUDA_DEFAULT, @@ -257,6 +259,7 @@ public void onDeallocated(long sizeDeallocated) { assertEquals(1024, totalDeallocated.get()); } + @Tag("noSanitizer") @Test public void testSetEventHandlerTwice() { Rmm.initialize(RmmAllocationMode.CUDA_DEFAULT, Rmm.logToStderr(), 0L); @@ -278,6 +281,7 @@ public boolean onAllocFailure(long sizeRequested, int retryCount) { assertThrows(RmmException.class, () -> Rmm.setEventHandler(otherHandler)); } + @Tag("noSanitizer") @Test public void testClearEventHandler() { Rmm.initialize(RmmAllocationMode.CUDA_DEFAULT, Rmm.logToStderr(), 0L); @@ -304,6 +308,7 @@ public boolean onAllocFailure(long sizeRequested, int retryCount) { } } + @Tag("noSanitizer") @Test public void testAllocOnlyThresholds() { final AtomicInteger allocInvocations = new AtomicInteger(0); @@ -367,6 +372,7 @@ public void onDeallocThreshold(long totalAllocSize) { assertEquals(0, deallocInvocations.get()); } + @Tag("noSanitizer") @Test public void testThresholds() { final AtomicInteger allocInvocations = new AtomicInteger(0); @@ -451,6 +457,7 @@ public void onDeallocThreshold(long totalAllocSize) { assertEquals(2, deallocInvocations.get()); } + @Tag("noSanitizer") @Test public void testExceptionHandling() { Rmm.initialize(RmmAllocationMode.POOL, Rmm.logToStderr(), 1024 * 1024L); @@ -511,6 +518,7 @@ public void testThreadAutoDeviceSetup() throws Exception { } } + @Tag("noSanitizer") @ParameterizedTest @ValueSource(ints = { RmmAllocationMode.CUDA_DEFAULT, @@ -523,6 +531,7 @@ public void testSetDeviceThrowsAfterRmmInit(int rmmAllocMode) { Cuda.autoSetDevice(); } + @Tag("noSanitizer") @Test public void testPoolSize() { Rmm.initialize(RmmAllocationMode.POOL, Rmm.logToStderr(), 1024); @@ -535,6 +544,7 @@ public void testPoolSize() { } } + @Tag("noSanitizer") @Test public void testCudaAsyncMemoryResourceSize() { try { @@ -553,6 +563,7 @@ public void testCudaAsyncMemoryResourceSize() { } } + @Tag("noSanitizer") @Test public void testCudaAsyncIsIncompatibleWithManaged() { assertThrows(IllegalArgumentException.class, diff --git a/java/src/test/java/ai/rapids/cudf/TableTest.java b/java/src/test/java/ai/rapids/cudf/TableTest.java index 94de3c6a11c..f17197ef608 100644 --- a/java/src/test/java/ai/rapids/cudf/TableTest.java +++ b/java/src/test/java/ai/rapids/cudf/TableTest.java @@ -40,6 +40,7 @@ import org.apache.parquet.schema.GroupType; import org.apache.parquet.schema.MessageType; import org.apache.parquet.schema.OriginalType; +import org.junit.jupiter.api.Tag; import org.junit.jupiter.api.Test; import java.io.*; @@ -8602,6 +8603,9 @@ void testORCWriteToFileWithColNames() throws IOException { } } + // https://github.com/NVIDIA/spark-rapids-jni/issues/1338 + // Need to remove this tag if #1338 is fixed. + @Tag("noSanitizer") @Test void testORCReadAndWriteForDecimal128() throws IOException { File tempFile = File.createTempFile("test", ".orc"); diff --git a/java/src/test/java/ai/rapids/cudf/UnsafeMemoryAccessorTest.java b/java/src/test/java/ai/rapids/cudf/UnsafeMemoryAccessorTest.java index b7cadb2786a..a3684cb42b9 100644 --- a/java/src/test/java/ai/rapids/cudf/UnsafeMemoryAccessorTest.java +++ b/java/src/test/java/ai/rapids/cudf/UnsafeMemoryAccessorTest.java @@ -1,6 +1,6 @@ /* * - * Copyright (c) 2019, NVIDIA CORPORATION. + * Copyright (c) 2019-2023, NVIDIA CORPORATION. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -18,11 +18,13 @@ package ai.rapids.cudf; +import org.junit.jupiter.api.Tag; import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; import static org.junit.jupiter.api.Assertions.assertNotEquals; +@Tag("noSanitizer") public class UnsafeMemoryAccessorTest { @Test public void testAllocate() {