From 0bdf934f6017402b88c9c0fe798013203af8c39f Mon Sep 17 00:00:00 2001 From: Srinivas Yadav <43375352+srinivasyadav18@users.noreply.github.com> Date: Mon, 17 Jun 2024 19:46:16 -0700 Subject: [PATCH] Reduce conditional_join nvbench configurations (#16036) The current **JOIN_NVBENCH** uses three table sizes `1000, 100'000, 10'000'000` for all the **join** benchmarks. But, **coditional** **joins** perform **X * Y** operations, and the large table size explodes the bench runtime. Hence we need to benchmark on smaller tables only. This PR reduces **nvbench configurations** from **36** to **16** by using only two smaller table sizes `1000, 100'000` which lowers the overall benchmark runtime significantly. Authors: - Srinivas Yadav (https://github.com/srinivasyadav18) Approvers: - Yunsong Wang (https://github.com/PointKernel) - Karthikeyan (https://github.com/karthikeyann) URL: https://github.com/rapidsai/cudf/pull/16036 --- cpp/benchmarks/join/conditional_join.cu | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/cpp/benchmarks/join/conditional_join.cu b/cpp/benchmarks/join/conditional_join.cu index e332d09d31b..2deb888cc5c 100644 --- a/cpp/benchmarks/join/conditional_join.cu +++ b/cpp/benchmarks/join/conditional_join.cu @@ -16,6 +16,8 @@ #include "join_common.hpp" +auto const CONDITIONAL_JOIN_SIZE_RANGE = std::vector{1000, 100'000}; + template void nvbench_conditional_inner_join(nvbench::state& state, nvbench::type_list>) @@ -46,12 +48,12 @@ NVBENCH_BENCH_TYPES(nvbench_conditional_inner_join, NVBENCH_TYPE_AXES(JOIN_KEY_TYPE_RANGE, JOIN_NULLABLE_RANGE)) .set_name("conditional_inner_join") .set_type_axes_names({"Key", "Nullable"}) - .add_int64_axis("left_size", JOIN_SIZE_RANGE) - .add_int64_axis("right_size", JOIN_SIZE_RANGE); + .add_int64_axis("left_size", CONDITIONAL_JOIN_SIZE_RANGE) + .add_int64_axis("right_size", CONDITIONAL_JOIN_SIZE_RANGE); NVBENCH_BENCH_TYPES(nvbench_conditional_left_join, NVBENCH_TYPE_AXES(JOIN_KEY_TYPE_RANGE, JOIN_NULLABLE_RANGE)) .set_name("conditional_left_join") .set_type_axes_names({"Key", "Nullable"}) - .add_int64_axis("left_size", JOIN_SIZE_RANGE) - .add_int64_axis("right_size", JOIN_SIZE_RANGE); + .add_int64_axis("left_size", CONDITIONAL_JOIN_SIZE_RANGE) + .add_int64_axis("right_size", CONDITIONAL_JOIN_SIZE_RANGE);