From 84833e7f3f2f6fe4ccec3de890cb9966b29c9afd Mon Sep 17 00:00:00 2001 From: Ryan Lee Date: Mon, 9 May 2022 18:53:30 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Bradley Dice --- cpp/include/cudf/table/experimental/row_operators.cuh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpp/include/cudf/table/experimental/row_operators.cuh b/cpp/include/cudf/table/experimental/row_operators.cuh index 76daa6dbca4..98ccd6c2b8c 100644 --- a/cpp/include/cudf/table/experimental/row_operators.cuh +++ b/cpp/include/cudf/table/experimental/row_operators.cuh @@ -90,7 +90,6 @@ namespace lexicographic { */ template class device_row_comparator { - // friend class device_less_comparator; friend class self_comparator; /** * @brief Construct a function object for performing a lexicographic @@ -281,6 +280,9 @@ class device_row_comparator { * @brief Wraps and interprets the result of templated Comparator that returns a weak_ordering. * Returns true if the weak_ordering matches any of the templated values. * + * Note that this should never be used with only `weak_ordering::EQUIVALENT`. + * An equality comparator should be used instead for optimal performance. + * * @tparam Comparator generic comparator that returns a weak_ordering. * @tparam values weak_ordering parameter pack of orderings to interpret as true */