From 0410bf9d654ed8f82ea74a2a3b337614c2795b4d Mon Sep 17 00:00:00 2001
From: David Wendt <45795991+davidwendt@users.noreply.github.com>
Date: Tue, 17 Aug 2021 16:48:35 -0400
Subject: [PATCH] Remove some debug print statements from gtests (#9048)

While working on #8883 I found some print statements that were a bit annoying while trying to narrow done the cuda-memcheck errors. This PR removes them. I don't think any of these are hard to recode if needed for a specific debug session but I feel they should not be inflicted on developers who are debugging other issues.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Vukasin Milovanovic (https://github.com/vuule)
  - Nghia Truong (https://github.com/ttnghia)

URL: https://github.com/rapidsai/cudf/pull/9048
---
 cpp/tests/encode/encode_tests.cpp          |  3 ---
 cpp/tests/rolling/grouped_rolling_test.cpp | 26 ----------------------
 cpp/tests/rolling/rolling_test.cpp         | 13 -----------
 cpp/tests/structs/structs_column_tests.cpp |  5 -----
 4 files changed, 47 deletions(-)

diff --git a/cpp/tests/encode/encode_tests.cpp b/cpp/tests/encode/encode_tests.cpp
index 52244b38dfe..73c77a39a97 100644
--- a/cpp/tests/encode/encode_tests.cpp
+++ b/cpp/tests/encode/encode_tests.cpp
@@ -67,9 +67,6 @@ TYPED_TEST(EncodeNumericTests, SimpleWithNulls)
   cudf::test::fixed_width_column_wrapper<TypeParam> expect_keys{{1, 2, 3, 0}, {1, 1, 1, 0}};
   auto const result = cudf::encode(cudf::table_view({input}));
 
-  cudf::test::print(result.first->view().column(0));
-  cudf::test::print(expect_keys);
-
   CUDF_TEST_EXPECT_COLUMNS_EQUAL(result.first->view().column(0), expect_keys);
   CUDF_TEST_EXPECT_COLUMNS_EQUAL(result.second->view(), expect);
 }
diff --git a/cpp/tests/rolling/grouped_rolling_test.cpp b/cpp/tests/rolling/grouped_rolling_test.cpp
index cb123114fd8..72b30c19fd5 100644
--- a/cpp/tests/rolling/grouped_rolling_test.cpp
+++ b/cpp/tests/rolling/grouped_rolling_test.cpp
@@ -139,19 +139,6 @@ class GroupedRollingTest : public cudf::test::BaseFixture {
     auto reference = create_reference_output(
       op, input, expected_grouping, preceding_window, following_window, min_periods);
 
-#ifndef NDEBUG
-    std::cout << "input:\n";
-    cudf::test::print(input, std::cout, ", ");
-    std::cout << "\n";
-    std::cout << "output:\n";
-    cudf::test::print(*output, std::cout, ", ");
-    std::cout << "\n";
-    std::cout << "reference:\n";
-    cudf::test::print(*reference, std::cout, ", ");
-    std::cout << "\n";
-    std::cout << "\n";
-#endif
-
     CUDF_TEST_EXPECT_COLUMNS_EQUAL(*output, *reference);
   }
 
@@ -709,19 +696,6 @@ class GroupedTimeRangeRollingTest : public cudf::test::BaseFixture {
                                              following_window_in_days,
                                              min_periods);
 
-#ifndef NDEBUG
-    std::cout << "input:\n";
-    cudf::test::print(input, std::cout, ", ");
-    std::cout << "\n";
-    std::cout << "output:\n";
-    cudf::test::print(*output, std::cout, ", ");
-    std::cout << "\n";
-    std::cout << "reference:\n";
-    cudf::test::print(*reference, std::cout, ", ");
-    std::cout << "\n";
-    std::cout << "\n";
-#endif
-
     CUDF_TEST_EXPECT_COLUMNS_EQUAL(*output, *reference);
   }
 
diff --git a/cpp/tests/rolling/rolling_test.cpp b/cpp/tests/rolling/rolling_test.cpp
index a67e670acb7..ec88500fde1 100644
--- a/cpp/tests/rolling/rolling_test.cpp
+++ b/cpp/tests/rolling/rolling_test.cpp
@@ -190,19 +190,6 @@ class RollingTest : public cudf::test::BaseFixture {
     auto reference =
       create_reference_output(op, input, preceding_window, following_window, min_periods);
 
-#if 0
-    std::cout << "input:\n";
-    cudf::test::print(input, std::cout, ", ");
-    std::cout << "\n";
-    std::cout << "output:\n";
-    cudf::test::print(*output, std::cout, ", ");
-    std::cout << "\n";
-    std::cout << "reference:\n";
-    cudf::test::print(reference, std::cout, ", ");
-    std::cout << "\n";
-    std::cout << "\n";
-#endif
-
     CUDF_TEST_EXPECT_COLUMNS_EQUAL(*output, *reference);
   }
 
diff --git a/cpp/tests/structs/structs_column_tests.cpp b/cpp/tests/structs/structs_column_tests.cpp
index 548284d6c87..a94a35e8896 100644
--- a/cpp/tests/structs/structs_column_tests.cpp
+++ b/cpp/tests/structs/structs_column_tests.cpp
@@ -433,11 +433,6 @@ TYPED_TEST(TypedStructColumnWrapperTest, TestListsOfStructs)
 
   cudf::test::expect_columns_equivalent(expected_unchanged_struct_col,
                                         cudf::lists_column_view(*list_col).child());
-
-#ifndef NDEBUG
-  std::cout << "Printing list col: \n";
-  cudf::test::print(*list_col);
-#endif
 }
 
 TYPED_TEST(TypedStructColumnWrapperTest, ListOfStructOfList)