-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SciPy's KDTree instead of deprecated cKDTree #733
Use SciPy's KDTree instead of deprecated cKDTree #733
Conversation
* was previously only being tested indirectly via tests for peak_local_max
Some nvjitlink-related failure occurs in CuPy for the conda test cases. Not sure if it is related to the recent CuPy 13.1.0 release or some other cause. Failures have the following form
|
After offline discussion, think this was an issue in the CuPy packages that was fixed recently with PR: conda-forge/cupy-feedstock#269 Restarting CI |
| After offline discussion, think this was an issue in the CuPy packages that was fixed recently with PR: conda-forge/cupy-feedstock#269 Was just going to ping you and ask, but saw you already resolved the issue. Thanks @jakirkham! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the recipe need to be updated too?
https://github.com/rapidsai/cucim/blob/branch-24.06/conda/recipes/cucim/meta.yaml#L82
Yes Greg could you please update these lines? cucim/conda/recipes/cucim/meta.yaml Line 69 in edd1da3
cucim/conda/recipes/cucim/meta.yaml Line 82 in edd1da3
|
@raydouglass , @jakirkham : Thanks, I have now updated the pinning in the conda recipe |
/merge |
Thanks Greg and Ray! 🙏 |
Functionality is equivalent since SciPy 1.6 (see note here).
I pinned SciPy to >= 1.6 (released Dec 31, 2020)
This MR also adds some missing test cases for the
_ensure_spacing
helper function used bycucim.skimage.feature.peak_local_max
. The new tests revealed a bug in that function in the case of non-scalarspacing
which is now fixed.Also, CuPy recently added KDTree so we can hopefully improve performance by moving to that in the future. I opened issue #732 as a reminder to investigate that.