-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align conda and wheel building workflows #44
Comments
A separate but related topic that may make sense to address somewhat in parallel is finding a way to make some subsets of the scripts reusable. Some work was previously done to make the CI test scripts usable in other environments (e.g. rapidsai/raft#2165), so when aligning conda/wheels CI and finding ways to maximize shared code (e.g. both calling the same |
Put up a proposal for this in rapidsai/gha-tools#105 |
This is dependent on C++ wheels work and team will start work on this one, once the C++ work is done. |
Historically our conda and wheel GHA workflow scripts have looked fairly different for a number of reasons. However, with #33 many of the fundamental distinctions will no longer exist because wheels will also have separate build steps for C++ and Python builds. As a result, we should invest in aligning our workflows as much as possible so as to reduce maintenance costs going forward. Some changes that we ought to make:
RAPIDS_PY_WHEEL_NAME
. In the PRs for Support dynamic linking between RAPIDS wheels #33 we're currently abusingRAPIDS_PY_WHEEL_NAME
to handle the CUDA version, so we need to start adding it for wheels before we can get rid of that variable.rapids-download-conda-from-s3
automates choosing the output directory, whilerapids-download-wheels-from-s3
requires that the caller specify it. We should update the wheel tool to automate that too.build_wheel_*
, whereas conda is justbuild_cpp.sh
etc. That is an artifact of a time when conda was our only produced artifact.rapids-wheels-anaconda
tool will need to be modified to support upload of cpp wheels.I will update this list as more ideas come to mind.
The text was updated successfully, but these errors were encountered: