Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate C++ include grouping and ordering using .clang-format #20

Closed
6 of 7 tasks
harrism opened this issue Feb 10, 2024 · 3 comments
Closed
6 of 7 tasks

Automate C++ include grouping and ordering using .clang-format #20

harrism opened this issue Feb 10, 2024 · 3 comments
Assignees
Labels
feature request New feature or request non-breaking Introduces a non-breaking change

Comments

@harrism
Copy link
Member

harrism commented Feb 10, 2024

We want to add rules to RAPIDS repos clang-format files to automate the C++ include grouping and ordering to ensure consistency and make it easier to write scripts that insert includes into C++ files. Such scripts would not have to worry about placing the includes in the right place because clang-format will fix up any ordering or grouping problems after running the script.

Full discussion in the cuDF PR.

@harrism harrism added feature request New feature or request non-breaking Introduces a non-breaking change labels Feb 10, 2024
@harrism harrism self-assigned this Feb 10, 2024
@bdice
Copy link
Contributor

bdice commented Mar 7, 2024

@harrism All the linked issues are closed. Do you have any other repos to work on before closing this issue?

@harrism
Copy link
Member Author

harrism commented Mar 11, 2024

I don't want to do more work on this than necessary. I'm sure there are other RAPIDS repos that need clang header grouping... If there are other RAPIDS repos that also use rmm::device_memory_resource* then I can do the work, otherwise maybe we can delegate. :)

@bdice
Copy link
Contributor

bdice commented Mar 18, 2024

@harrism I'll close this for now, since it seems like all the repos are completed. If you find that more work is needed, please feel free to reopen.

@bdice bdice closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

No branches or pull requests

2 participants