Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configured URLs cannot use https #25

Open
garethbowen opened this issue Oct 13, 2020 · 5 comments
Open

Configured URLs cannot use https #25

garethbowen opened this issue Oct 13, 2020 · 5 comments

Comments

@garethbowen
Copy link

When configuring the app to use a custom RapidPro deployment, the code automatically prefixes http but we need to use https. We should be able to specify which protocol to use.

@nicpottier
Copy link
Member

Happy to take a PR if you want to submit one.

@WaluQ
Copy link

WaluQ commented Dec 14, 2020

Facing this same challenge, any workaround this issue? The app is failing to sync with the server as the POST message is prefixing http:// and port number 8000 to any IP address I enter, but our server is not recognizing both as it's using https:// and 443.

@nicpottier
Copy link
Member

Again, happy to take a PR for this.

@WaluQ
Copy link

WaluQ commented Dec 15, 2020

Again, happy to take a PR for this.

does this mean no one has submitted a PR for this issue before? Would have thought it to be an urgent issue. :)

@WaluQ
Copy link

WaluQ commented Dec 15, 2020

I believe this is the code in question and would gladly send a PR but would'nt want to practice on a live project.
// if our endpoint is an ip, add :8000 to it if (endpoint.startsWith("ip")) { endpoint = "http://" + ip; if (!ip.contains(":")) { endpoint += ":8000"; } } String endpoint = RapidPro.get().getServerURL(context);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants