Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please consider using HTTPS instead of HTTP #6

Open
jeffWelling opened this issue Jan 8, 2020 · 0 comments · May be fixed by #7
Open

Please consider using HTTPS instead of HTTP #6

jeffWelling opened this issue Jan 8, 2020 · 0 comments · May be fixed by #7

Comments

@jeffWelling
Copy link

Hello, and thank you lovely folks for putting together a puppet module for installing Nexpose! It's been helpful in writing an equivalent for Saltstack.

One thing I noticed though is that this puppet module appears to be downloading the Nexpose binary via HTTP, and when I tested this just now, it appears to work over HTTPS as well.

root@nexpose:~# wget http://download2.rapid7.com/download/NeXpose-v4/NeXposeSetup-Linux64.bin
--2020-01-08 04:25:59--  http://download2.rapid7.com/download/NeXpose-v4/NeXposeSetup-Linux64.bin
Resolving download2.rapid7.com (download2.rapid7.com)... 104.100.53.23
Connecting to download2.rapid7.com (download2.rapid7.com)|104.100.53.23|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 937419063 (894M) [application/octet-stream]
Saving to: ‘NeXposeSetup-Linux64.bin’

NeXposeSetup-Linux64.bin   100%[========================================>] 893.99M  16.6MB/s    in 53s

2020-01-08 04:26:52 (17.0 MB/s) - ‘NeXposeSetup-Linux64.bin’ saved [937419063/937419063]

root@nexpose:~# rm NeXposeSetup-Linux64.bin
root@nexpose:~# wget https://download2.rapid7.com/download/NeXpose-v4/NeXposeSetup-Linux64.bin
--2020-01-08 04:27:20--  https://download2.rapid7.com/download/NeXpose-v4/NeXposeSetup-Linux64.bin
Resolving download2.rapid7.com (download2.rapid7.com)... 104.100.53.23
Connecting to download2.rapid7.com (download2.rapid7.com)|104.100.53.23|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 937419063 (894M) [application/octet-stream]
Saving to: ‘NeXposeSetup-Linux64.bin’

NeXposeSetup-Linux64.bin   100%[========================================>] 893.99M  4.66MB/s    in 3m 27s

2020-01-08 04:30:47 (4.32 MB/s) - ‘NeXposeSetup-Linux64.bin’ saved [937419063/937419063]

https://github.com/rapid7/puppet-nexpose/blob/production/manifests/params.pp#L18

Would you consider altering the default to use HTTPS instead of HTTP?

Thanks again, and happy hacking!
jeffWelling added a commit to jeffWelling/puppet-nexpose that referenced this issue Jan 8, 2020
@jeffWelling
Use HTTPS for NeXpose binary
4a9b840 
Resolves rapid7#6
This was referenced Jan 8, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jeffWelling