Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure compatibility with numpy 2.0 #444

Closed
Tracked by #279
raphaelvallat opened this issue Oct 8, 2024 · 4 comments
Closed
Tracked by #279

ensure compatibility with numpy 2.0 #444

raphaelvallat opened this issue Oct 8, 2024 · 4 comments
Assignees
Labels
feature request 🚧 New feature or request

Comments

@raphaelvallat
Copy link
Owner

See the NumPy 2.0 migration guide

@raphaelvallat raphaelvallat added the feature request 🚧 New feature or request label Oct 8, 2024
@raphaelvallat raphaelvallat self-assigned this Oct 8, 2024
@raphaelvallat raphaelvallat changed the title compatibility with numpy 2.0 ensure compatibility with numpy 2.0 Oct 8, 2024
@remrama
Copy link
Contributor

remrama commented Oct 8, 2024

It's probably straightforward to run Ruff's rule once on the pingouin code to conform to Numpy 2.0. But @raphaelvallat are you cool with simultanously replacing both Black and Flake8 with Ruff? It should be configurable within pyproject.toml to match the current rules of both. They also offer a drop-in GitHub Action workflow that could replace pingouin's current Black Action. I've implemented this before on a recent project and found it a convenient one-stop solution for these things.

@raphaelvallat
Copy link
Owner Author

Yeah, I keep hearing good things about ruff so let's change

@remrama
Copy link
Contributor

remrama commented Oct 9, 2024

Adding a checklist for this Issue that combines goals of numpy 2.0 compatibility with ruff replacement.

  • Replace black with ruff in pyproject.toml
  • Replace flake8 with ruff in pyproject.toml
  • Replace black GitHub Action with ruff GitHub action
  • Run ruff's formatter (in case of minor deviations from black)
  • Run ruff's linter (in case of minor deviations from flake8)
  • Run ruff's numpy 2.0 compatibility enforcer
  • Replace black and flake8 with ruff in Contributing sections in docs and README.

@remrama
Copy link
Contributor

remrama commented Dec 8, 2024

@raphaelvallat this got addressed when #446 was merged, so you can close it as completed 👍 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🚧 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants