Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #3

Open
omegaga opened this issue Apr 26, 2016 · 0 comments
Open

Refactoring #3

omegaga opened this issue Apr 26, 2016 · 0 comments

Comments

@omegaga
Copy link
Collaborator

omegaga commented Apr 26, 2016

We need to do some refactoring. Some are listed below:

  1. Message handlers should be wrapped in functions. DONE
  2. When duplicate prepare statement name occurs, plan cache should reject and return error to frontend
  3. Plan cache and portals should be stored in PacketManager, instead of a thread_local variable2
  4. Add query_type to plan cache so we don't need to read it again in BIND message
  5. variable name row_affected is misleading, change to a more appropriate name
  6. We should use a generic value type in BIND message, instead of converting to string and back into data types
  7. Check if we do unnecessary copying for strings, vectors, etc.
  8. Replace ASSERT to error handling code to make our code more robust
  9. Other 'TODO's in code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant