Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Avoid re-computing tree hashes #67

Open
ranocha opened this issue Aug 9, 2022 · 0 comments
Open

Performance: Avoid re-computing tree hashes #67

ranocha opened this issue Aug 9, 2022 · 0 comments
Labels
performance We are greedy

Comments

@ranocha
Copy link
Owner

ranocha commented Aug 9, 2022

Code such as

BSeries.jl/src/BSeries.jl

Line 775 in 8bb9b95

series[t] = series_integrator[t]

or

BSeries.jl/src/BSeries.jl

Line 956 in 8bb9b95

series[t] += series_ex[t] - substitute(series, series_integrator, t)

basically computes the hash of the tree t twice. Sadly, there is no stable Base API functionality to avoid this, see https://discourse.julialang.org/t/document-export-ht-keyindex-from-dict-jl/83738 and JuliaLang/julia#33758.
It may be worth checking https://github.com/andyferris/Dictionaries.jl as an alternative.
@ranocha ranocha added the performance We are greedy label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance We are greedy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ranocha