Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle mixins #32

Open
cbizon opened this issue Jan 31, 2021 · 1 comment
Open

How to handle mixins #32

cbizon opened this issue Jan 31, 2021 · 1 comment

Comments

@cbizon
Copy link
Contributor

cbizon commented Jan 31, 2021

biolink does have a form of multiple inheritance, implemented as mixins, and has been moving more and more union classes into that. So for instance GeneOrGeneProduct is now a mixin instead of a class.

One nice thing about e.g. that one being a class is that you could query while being somewhat insulated against modling choices that some individual team made about whether to call something a gene or a gene product.

But with a mixin, that's hidden. The mixins aren't meant to be used by users. Do we want to use them anyway? If so, it makes the reasoner more complicated because now there's multiple inheritance in the system.

@cbizon
Copy link
Contributor Author

cbizon commented Apr 7, 2021

Based on some later discussion, we do need to handle mixins to a degree. queries might show up with a mixin as an unbound node. This has been kind of a sticky problem because bmt hasn't allowed us to do descendents of mixins, but that is being fixed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant