Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other prerequisites needed #69

Open
richtong opened this issue Oct 4, 2016 · 1 comment
Open

Other prerequisites needed #69

richtong opened this issue Oct 4, 2016 · 1 comment

Comments

@richtong
Copy link
Contributor

richtong commented Oct 4, 2016

I'm not sure how active this project is, but some notes on installation:

  1. Bower is required for this to work as is gulp, so you should add to the README.md and then you need npm install -g bower gulp
  2. Also is reactify being used anymore, I see that the current build seems to install babelify instead. Is the README.md out of date?
  3. Also jest seems to be using react-tools to process the javascript and react-tools version is linked to a deprecated version. Seems like jest should use the same transformer as the main system. I was wondering why you did it this way? I thought the proper way was to use babel-jest and link it that way per https://github.com/facebook/jest and then you need to change the package.json to point to it a la http://stackoverflow.com/questions/28870296/how-to-use-jest-with-webpack so you need to change the "scriptPreProcessor" : "<root-dir>/node_modules/babel-jest"
@richtong
Copy link
Contributor Author

richtong commented Oct 5, 2016

Thanks for integrating the pull request. I'll add README.md change if there is another one :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant