Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bower_components/ missing from .gitignore #46

Open
mattclaw opened this issue Jun 9, 2015 · 4 comments
Open

bower_components/ missing from .gitignore #46

mattclaw opened this issue Jun 9, 2015 · 4 comments

Comments

@mattclaw
Copy link
Contributor

mattclaw commented Jun 9, 2015

Perhaps this is a matter of preference?

Please see PR #47

@mattclaw
Copy link
Contributor Author

mattclaw commented Jun 9, 2015

Looks like there are some good arguments for either side.

@randylien
Copy link
Owner

If we all only use NPM to manage our packages, we don't need Bower anymore.
But I know some packages you can't find from NPM.
Try to highlight this part in README.

@codeofsumit
Copy link

/bower_components/ is inside .gitignore, but it should be /app/bower_components/

@mattclaw
Copy link
Contributor Author

mattclaw commented Apr 18, 2016

.gitignore works by pattern matching, so you don't need to give the full relative path to your directory or file. The level of specificity is another matter of preference, but I would argue one reason to be less specific is to make it easy for someone to change the path to bower_components without having to touch .gitignore. Of course, you could then argue that a user who is sufficiently advanced enough to customize .bowerrc can also handle modifying .gitignore or might also choose a name that doesn't match bower_components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants