Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data section deleted on restart/reload #3

Open
Stampede2011 opened this issue Jul 5, 2020 · 7 comments
Open

Data section deleted on restart/reload #3

Stampede2011 opened this issue Jul 5, 2020 · 7 comments

Comments

@Stampede2011
Copy link

Stampede2011 commented Jul 5, 2020

I have added a Byte Item that is linked to an item from the CommandItems plugin into the config via "/bi save testitem". If I give the item to myself the item via "bi give testitem", it will work as a CommandItems because it has the "Data" section in the config (first config paste below). Once the server is restarted or reloaded, the entire "Data" section is removed from the config (second config paste below) and the item no longer works with CommandItems.

Config pre-restart/reload
items {
    testitem {
        ContentVersion=2
        Count=1
        Data=[
            {
                ContentVersion=2
                ManipulatorData {
                    ContentVersion=2
                    commanditem=default
                }
                ManipulatorId="commanditems:commanditem_data"
            }
        ]
        ItemType="minecraft:stone"
        UnsafeDamage=0
        UnsafeData {
            display {
                Lore=[
                    "§aThis is a magic item! Right click",
                    "§awith it to see what happens!"
                ]
                Name="§eSpetacular Stone"
            }
        }
    }
}
  
Config post-restart/reload
items {
    testitem {
        ContentVersion=2
        Count=1
        ItemType="minecraft:stone"
        UnsafeDamage=0
        UnsafeData {
            display {
                Lore=[
                    "§aThis is a magic item! Right click",
                    "§awith it to see what happens!"
                ]
                Name="§eSpetacular Stone"
            }
        }
    }
}
  
@randombyte-developer
Copy link
Owner

I suspect that a Sponge update changed that. Did this plugin ever work for you correctly?

@Stampede2011
Copy link
Author

Never tested it prior to this week! I could investigate further if needed

@randombyte-developer
Copy link
Owner

What I would do is to look for when this broke. So I would download a very old Sponge version (like 1 year ago) and test it. then 6 months ago, 3 months, 1.5 months, until it breaks. Not the exact build but like a 1 month range. Then I would ask if the is intended behavior from the Sponge API (on their Discord).
I don't have much time right now, I can have a look in 1 week.

@Stampede2011
Copy link
Author

This issue seems to appear even as far back as SpongeForge 2768 with every version of ByteItems from 2.2 to 2.4.1. Likley spans even further back or just doesn't work in any version.

@randombyte-developer
Copy link
Owner

Hm, I will look after that in like 4 days (still have to write exams).

@randombyte-developer
Copy link
Owner

Can confirm that on the latest SpongeVanilla

SpongeAPI: 7.2.0-e4abe364d
Sponge: 1.12.2-7.2.3
SpongeVanilla: 1.12.2-7.2.3

Will have to see what's causing it and if it is Sponge's fault or mine.

@randombyte-developer
Copy link
Owner

Reported: SpongePowered/Sponge#3079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants