-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would like to submit a pull request to add labels to vsphere charts #33
Comments
The linked PR is merged. |
@a-blender , we've already un-RCd vSphere CPI/CSI charts for the 2.8.0 release so it will be some time before we bring it into charts for testing. However, I see there are (unsurprisingly) some newer versions, especially for CSI provider (https://github.com/kubernetes-sigs/vsphere-csi-driver/releases) (much less for CPI https://github.com/kubernetes/cloud-provider-vsphere/releases). @a-blender , could you review the versions we're on vs. versions that are available and create issues in https://github.com/rancher/rancher to track those against the upcoming 2.8.x milestone (https://github.com/rancher/rancher/milestone/319). Please also mention this issue there as the other change included that needs testing/validation. FYI @jiaqiluo @daviswill2 |
Note: The previous comment is specific to Rancher side of things. For RKE2 side, pinging @cwayne18 @caroline-suse-rancher @brandond . |
@snasovich New vsphere issues for the 2.8-Next1 release are created rancher/rancher#43494, rancher/rancher#43495. I've added this issue to the test checklist so it gets validated when the drivers are tested. |
Is your feature request related to a problem? Please describe.
Currently there is no way to add any custom pod labels for these charts unless I fork the chart and add them... they are hardcoded.
Describe the solution you'd like
I would like to add a helper function to add common chart helm labels as well as the ability to override a value to add podlabels
Describe alternatives you've considered
This is a easy update and really does not need an alternative. alternative would be to fork the chart and create your own object adds.
Additional context
I am creating this issue so that I can use this to track my pull request. I am waiting for my company to approve that I can do this then I will submit a pull with what I am thinking.
The text was updated successfully, but these errors were encountered: