Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter action on created PR #2

Open
thehejik opened this issue Jan 29, 2024 · 1 comment
Open

Add linter action on created PR #2

thehejik opened this issue Jan 29, 2024 · 1 comment
Assignees
@thehejik
Labels
fleet-e2e-ci Improvements or additions to the CI framework

Comments

@thehejik
Copy link
Collaborator

thehejik commented Jan 29, 2024 •
edited
Loading

  • it will be triggered on create PR event
  • it should be possible to run manually on selected PR/branch
  • this is gonna run on a gihub-runner
  • check cypress/typescript
  • check go/ginkgo
  • later we can enhance by some basic tests and using the PR code
@thehejik thehejik added the fleet-e2e-ci Improvements or additions to the CI framework label Jan 29, 2024
@thehejik thehejik self-assigned this Jan 29, 2024
@thehejik
Copy link
Collaborator Author

thehejik commented Feb 1, 2024

Linter from elemental doesn't catch obvious errors in go lang code and cypress eslint check has problems with annotations on github. This will require more investigation. Postponing for now.

@mmartin24 mmartin24 mentioned this issue Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thehejik thehejik

Labels
fleet-e2e-ci Improvements or additions to the CI framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehejik