Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts-build-scripts] add make charts validation blocking update on different charts #498

Open
nicholasSUSE opened this issue Oct 30, 2024 · 0 comments
Assignees

Comments

@nicholasSUSE
Copy link
Contributor

See this PR that is wrong: https://github.com/rancher/charts/pull/4664/commits

The longhorn team used make charts command without specifying the target package as longhorn.
They should have done this:

PACAKGE=longhorn make prepare
PACAKGE=longhorn make patch
make clean
PACAKGE=longhorn make charts

There is probably some development work going on the rancher-monitoring at the same time and since they did not specify the package, the index.yaml for the rancher-monitoring chart got modified.

This is wrong.

Task

Create some sort of GHA validation that detects changes like this and throw an error.

@nicholasSUSE nicholasSUSE self-assigned this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant