You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The longhorn team used make charts command without specifying the target package as longhorn.
They should have done this:
PACAKGE=longhorn make prepare
PACAKGE=longhorn make patch
make clean
PACAKGE=longhorn make charts
There is probably some development work going on the rancher-monitoring at the same time and since they did not specify the package, the index.yaml for the rancher-monitoring chart got modified.
This is wrong.
Task
Create some sort of GHA validation that detects changes like this and throw an error.
The text was updated successfully, but these errors were encountered:
See this PR that is wrong: https://github.com/rancher/charts/pull/4664/commits
The longhorn team used
make charts
command without specifying the target package as longhorn.They should have done this:
There is probably some development work going on the
rancher-monitoring
at the same time and since they did not specify the package, the index.yaml for the rancher-monitoring chart got modified.This is wrong.
Task
Create some sort of GHA validation that detects changes like this and throw an error.
The text was updated successfully, but these errors were encountered: