Allow Longhorn CSI storage driver to be selected #12682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Periods are used as a default key separator in Dashboard's i18n implementation. Using `-` instead of periods in our keys allows for a proper lookup of keys. Signed-off-by: Phillip Rak <[email protected]>
Options for CSI can be either a string or an object; objects contain a label property. Replace periods with `-` in keys like `driver.longhorn.io` so that the i18n implementation will properly match a translation. Signed-off-by: Phillip Rak <[email protected]>
The `name` prop for tabs assigns an id to a `section` element in the underlying tab. Since ids must be unique in the document, there conflicts can arise when programmatically selecting tabs. Signed-off-by: Phillip Rak <[email protected]>
Signed-off-by: Phillip Rak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves an issue with selecting options for Pod Storage: CSI. It appears that there are two different ways that an option can be represented, by either being a string or an object with a label key. It also appears that periods are exclusively used for i18n selectors, so the key for Longhorn has been updated to use
-instead.Fixes #11899
Occurred changes and/or fixed issues
-in keys likedriver.longhorn.ioso that the i18n implementation will properly match a translation.Technical notes summary
Areas or cases that should be tested
See associated issue for more instructions.
Areas which could experience regressions
Checklist