-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @types/node
to 20.17.6
#12616
base: master
Are you sure you want to change the base?
Bump @types/node
to 20.17.6
#12616
Conversation
bbf1ae9
to
3839d1d
Compare
shell/package.json
Outdated
@@ -161,7 +161,7 @@ | |||
"roarr": "7.0.4", | |||
"semver": "7.5.4", | |||
"@types/lodash": "4.17.5", | |||
"@types/node": "~20.10.0", | |||
"@types/node": "20.17.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can consider sticking to 20.10.8
if this is known to be working in shell. I only went with 20.17.6
because this is the latest available for node 20.
@rak-phillip the key here is the All extensions migrated to vue3 have this resolution for "@types/node": "~20.10.0" |
Signed-off-by: Phillip Rak <[email protected]>
3839d1d
to
d99dbca
Compare
@aalves08 Then it's settled, |
Hopefully we can, mate! 🤞 🤞 🤞 no it's just a matter of testing it with extensions |
I've just generated a new extension via
We need to clean this up and consolidate it... This hasn't been touched in a bit (I forgot to update them 💦 when I reviewed some dependencies). In theory it should only be:
|
I've yarn linked your branch to a newly generated extension with just the
And the build failed with |
Summary
This bumps
@types/node
to 20.17.6.@types/node
was recently targeting node 16, which Dashboard no longer supports as of the Vue 3 migration.Occurred changes and/or fixed issues
@types/node
to 20.17.6Technical notes summary
Checklist