Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Vue3: require.context provides duplicate entries #11773

Closed
2 tasks done
richard-cox opened this issue Aug 29, 2024 · 4 comments
Closed
2 tasks done

[Epic] Vue3: require.context provides duplicate entries #11773

richard-cox opened this issue Aug 29, 2024 · 4 comments
Assignees
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Aug 29, 2024

Setup

  • Rancher version: dev of 2.10.0

Describe the bug

To Reproduce

Case 2

  • Requires adding a custom step to an existing chart's form components (WIP)

Case 3

  • N/A

Case 5 & 6

  • Cluster Explorer --> Workloads --> Deployments --> Create --> Pod tab --> Storage vertical tab --> Select CSI
  • Cluster Explorer --> Workloads --> Deployments --> Create --> Pod tab --> Storage vertical tab --> Select Ephemeral Volume

Screenshots

Additional context

  • recommend short term fix of custom require.context that filters out resources not starting with ./
  • Does not happen with below, given second below
    • const _NAME = require.context('BASE/DIR', true, /\.(vue|js|yaml)$/).keys(); 
      
    • Translates to
      const _l10n = require.context('@pkg/aks/l10n', true, /\.(vue|js|yaml)$/).keys();  
      
@richard-cox richard-cox added kind/bug area/vue3 Bugs and technical debts as outcome to the Vue3 migration labels Aug 29, 2024
@richard-cox richard-cox added this to the v2.10.0 milestone Aug 29, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Aug 29, 2024
@rak-phillip rak-phillip self-assigned this Aug 30, 2024
@rak-phillip rak-phillip changed the title Vue3: require.context provides duplicate entries [Epic] Vue3: require.context provides duplicate entries Aug 30, 2024
@rak-phillip
Copy link
Member

I started work on splitting this out into separate issues before getting distracted by #11787. wrt require.contex() it looks like the move from Webpack4 to Webpack5 has changed the behavior a little bit, most notably (in the context of #11787), paths now include a relative path (e.g. shell/edit/workload/storage/Mount.vue); this was breaking the filter for excluded files.

We might find other inconsistencies between Webpack4/5 as we investigate other areas that utilize require.context()

@richard-cox
Copy link
Member Author

@rak-phillip i've updated the issue (spun out anything not related and validated others). only top item in check list pending on this epic

@rak-phillip
Copy link
Member

Thanks! Moving this epic out of triage

@rak-phillip rak-phillip removed their assignment Sep 13, 2024
@rak-phillip
Copy link
Member

rak-phillip commented Sep 25, 2024

We are closing this epic and allowing #11786 to be handled on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vue3 Bugs and technical debts as outcome to the Vue3 migration kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

2 participants