Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.9] BRO not backing up namespaces created for FleetWorkspaces #589

Closed
github-actions bot opened this issue Sep 23, 2024 · 2 comments
Closed

[v2.9] BRO not backing up namespaces created for FleetWorkspaces #589

github-actions bot opened this issue Sep 23, 2024 · 2 comments
Assignees
Milestone

Comments

@github-actions
Copy link

This is a forwardport issue for #482, automatically created via GitHub Actions workflow initiated by @mallardduck

Original issue body:

Rancher Server Setup

  • Rancher version: 2.8.1
  • Installation option (Docker install/Helm Chart): Helm Install
  • Kubernetes Version and Engine: v1.25.4+rke2r1

SURE-8919

Describe the bug
When using FleetWorkspaces in Rancher this will create a new namespace for said workspace. Due to this if a user attempts to restore on a new cluster the restore process will fail as it will not create said namespace.

To Reproduce
Steps to reproduce the behavior:

  1. Create a fresh cluster
  2. Create FleetWorkspaces (See additional context below)
  3. Install backup operator and take a backup
  4. Delete cluster
  5. Restore Rancher on totally new cluster
  6. Observe restore failure

Expected behavior
I would expect one of two things to happen:

  1. Rancher restore should create the namespace as needed to allow the FleetWorkspace to be repopulated
  2. Rancher restore will skip creating FleetWorkspaces as to not prevent the restore from completing
    Option one is preferable but two will at leas prevent end users from getting stuck.

Screenshots
Not needed

Additional context
Sample Fleet config

---
apiVersion: management.cattle.io/v3
kind: FleetWorkspace
metadata:
  name: enterprise
 
---
apiVersion: management.cattle.io/v3
kind: FleetWorkspace
metadata:
  name: edge

---
apiVersion: fleet.cattle.io/v1alpha1
kind: ClusterGroup
metadata:
  name: infra
  namespace: enterprise
spec:
  selector:
    matchExpressions: []
    matchLabels:
      infra: "true"
---
apiVersion: fleet.cattle.io/v1alpha1
kind: ClusterGroup
metadata:
  name: apps
  namespace: edge
spec:
  selector:
    matchExpressions: []
    matchLabels:
      apps: "true"
@github-actions github-actions bot added this to the v2.9.3 milestone Sep 23, 2024
@mallardduck mallardduck changed the title [forwardport v2.9.3] BRO not backing up namespaces created for FleetWorkspaces [2.9.3] BRO not backing up namespaces created for FleetWorkspaces Sep 23, 2024
@mallardduck
Copy link
Member

mallardduck commented Sep 23, 2024

The primary PR for this is merged into main: #577
This issue is for tracking the PR to merge into 5.0/2.9: #578


For QA use - this issue with track this PR: #578
This release will have Charts usable for QA: https://github.com/rancher/backup-restore-operator/releases/tag/v5.0.2-rc.1

@mallardduck mallardduck added the fleet Related to fleet integration label Sep 23, 2024
@mallardduck mallardduck changed the title [2.9.3] BRO not backing up namespaces created for FleetWorkspaces [v2.9] BRO not backing up namespaces created for FleetWorkspaces Sep 23, 2024
@nickwsuse
Copy link

Verified on v2.9-head ID: 7f4c4ec && Rancher Backups v104.0.2+up5.0.2-rc.2

No errors were recorded in the restore logs for any of the following tests, and the workspaces were successfully restored.

Fresh Install

  1. Rancher Backups resourceSet shows updated regex for fleet workspaces ✅
  2. In-Place restore after creating Fleet workspaces and deleting a cluster ✅
  3. RKE1 local with RKE1 downstream cluster ✅
  4. RKE1 local with RKE2 downstream cluster ✅
  5. RKE1 local with RKE1 downstream cluster migrated to RKE2 local ✅
  6. RKE1 local with RKE2 downstream cluster migrated to RKE2 local ✅
  7. RKE2 local with RKE1 downstream cluster migrated to RKE2 local ✅
  8. RKE2 local with RKE2 downstream cluster migrated to RKE2 local ✅

Upgrade

  1. Rancher Backups resourceSet shows updated regex for fleet workspaces ✅
  2. In-Place restore after creating Fleet workspaces and deleting a cluster ✅
  3. RKE1 local with RKE1 downstream cluster ✅
  4. RKE1 local with RKE2 downstream cluster ✅
  5. RKE1 local with RKE1 downstream cluster migrated to RKE2 local ✅
  6. RKE1 local with RKE2 downstream cluster migrated to RKE2 local ✅
  7. RKE2 local with RKE1 downstream cluster migrated to RKE2 local ✅
  8. RKE2 local with RKE2 downstream cluster migrated to RKE2 local ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants