Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update derive_builder #131

Closed
Plecra opened this issue Sep 27, 2020 · 1 comment · Fixed by #129
Closed

Update derive_builder #131

Plecra opened this issue Sep 27, 2020 · 1 comment · Fixed by #129

Comments

@Plecra
Copy link

Plecra commented Sep 27, 2020

This dependency draws in pre-1.0 versions of proc_macro2 and syn, which will be duplicated in most codebases. derive_builder 0.8 updated to use the 1.0 versions of proc_macro and syn, which would improve the build times of most crates that depend on rspotify
@Plecra Plecra mentioned this issue Sep 27, 2020
Closed
@ramsayleung
Copy link
Owner

We are working on refactoring rspotify and derive_builder has been updated to 0.9:

rspotify/Cargo.toml

Line 19 in 32dff3a

derive_builder = "0.9.0"

@marioortizmanero marioortizmanero mentioned this issue Oct 10, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple clients via features ramsayleung/rspotify
2 participants
@ramsayleung @Plecra