Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Transformation in Calibration::initCameraGroup #77

Open
stillfd opened this issue Aug 8, 2024 · 3 comments
Open

Incorrect Transformation in Calibration::initCameraGroup #77

stillfd opened this issue Aug 8, 2024 · 3 comments

Comments

@stillfd
Copy link

stillfd commented Aug 8, 2024

Hi,
i noticed that when init cameragroup, the code gives incorrect initialization when the path length is larger than 2.
Seems the transformation should be updated by the equation: transform = current_trans*transform; in stead of the current one(transform = transform * current_trans; McCalib/src/McCalib.cpp, line 1128)

@rameau-fr
Copy link
Owner

Thank you for your interest and feedback.
We will investigate this potential bug and propose a correction if needed.
in your scenario, the original code fails to converge without your suggested adjustment?

@stillfd
Copy link
Author

stillfd commented Aug 8, 2024

Yes, its not converge in my scenario and after the modification the result converged.
i only use like ~200 pic(per cam) to estimate the pose of every cam, and the inital pose will highly affect the final result.
I noticed sometimes the pose of some cameras are obviously incorrect, so i go through the code and did several tests. and locate this "potential bug"

@shreyas23
Copy link

This seems to be a duplicate of #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants