Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cancellation ability in the BlindedBlockRelayer trait #114

Open
ralexstokes opened this issue Aug 16, 2023 · 0 comments · May be fixed by #131
Open

Support cancellation ability in the BlindedBlockRelayer trait #114

ralexstokes opened this issue Aug 16, 2023 · 0 comments · May be fixed by #131
Labels
build enhancement New feature or request good first issue Good for newcomers

Comments

@ralexstokes
Copy link
Owner

mev-rs/mev-rs/src/blinded_block_relayer/mod.rs

Lines 18 to 21 in 9d88a23

async fn submit_bid(
&self,
signed_submission: &SignedBidSubmission,
) -> Result<SignedBidReceipt, Error>;

submit_bid should support some way for the caller to signal they want to enable cancellations

going by the current API, it looks like can get away with just adding a bool param to this trait method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
1 participant
@ralexstokes