Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert / Modify PR #104 #121

Closed
lygamac opened this issue Mar 24, 2021 · 1 comment
Closed

Revert / Modify PR #104 #121

lygamac opened this issue Mar 24, 2021 · 1 comment

Comments

@lygamac
Copy link

lygamac commented Mar 24, 2021

The solution in PR #104 is not a viable solution for all users (there might be users using dark terminal with light colorscheme or vice-versa, or a different theme with makes the color incoherent.)

Suggestion, add:

if (&background == dark)
    " dark theme color codes
elseif (&background == light)
    " light theme color codes
endif 

The only drawback of this is to reload the plugin in order to perform an if check if the user switches the background.

@lygamac
Copy link
Author

lygamac commented Mar 26, 2021

Solved by #120

@lygamac lygamac closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant