Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int Null value handling #23

Open
Guy293 opened this issue Jun 10, 2018 · 2 comments
Open

Int Null value handling #23

Guy293 opened this issue Jun 10, 2018 · 2 comments

Comments

@Guy293
Copy link

Guy293 commented Jun 10, 2018

Change it to other random number.
Because if the player have -1 kill The program cant tell if its a null value or a real value.
Thank you,
Guy

@rakijah
Copy link
Owner

rakijah commented Jun 12, 2018

Hi,

I have to admit, I had not thought of that (mainly because I don't play CS:GO anymore). But I'm not sure if returning int.MinValue will be an acceptable solution.

I'm thinking of maybe switching everything over to nullable value types (int? and bool?) because returning anything other than null will always be misleading in some context. This would mean breaking a lot of code for everyone, though.

If you have any ideas/suggestions, please feel free to share them with me.

@Guy293
Copy link
Author

Guy293 commented Jun 12, 2018

It will break lot of codes.
Better solution will be to switch it to a lower number.
And at the same time make a fixed version with bool return or something...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants