How to mock with_for_update

[hmajid2301]

Hi,

Im struggling to mock out

session.query(Model).filter(Model.a != False).with_for_update()

Using the following (return_object just being a list of Model to return).

  session = UnifiedAlchemyMagicMock(
      data=[
          (
              [
                  mock.call.query(Model),
                  mock.call.filter(Model.a != False),
                  mock.call.with_for_update(),
              ],
              return_object,
          ),
      ]
  )

If I remove the mock.call.with_for_update(), the example below works.

session.query(Model).filter(Model.a != False).first()

[rajivsarvepalli]

mock.call.with_for_update() is not a supported command as of now. I believe this call returns a query which can be used later on. I will look into adding these types of commands. If I am not mistaken,

session.query(Model).filter(Model.a != False).with_for_update()

should return a query object, and not a list of objects according sqlalchemy documentation? Let me know what you think the expected behavior of the line

session.query(Model).filter(Model.a != False).with_for_update()

should be for the testing library. Would you expect a query object with some of the functionality of the query object in SQLAlchemy? I could look into adding that but that would be a considerable addition and therefore take some time.

[hmajid2301]

Yeh it's a good point, with_for_update() I believe is usually used to lock row it "touches" in the db. So I suppose for now if it just returns a query object back that is fine. The testing of the actual mechanism of locking could (and perhaps should be) done outside of unit tests.

[zeason]

@rajivsarvepalli Hi, just want to check if there is any progress on this?