Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xor selectors trait #4

Merged
merged 4 commits into from
Jun 19, 2024
Merged

add xor selectors trait #4

merged 4 commits into from
Jun 19, 2024

Conversation

rouzwelt
Copy link
Collaborator

Motivation

add a trait for types that implement SolInterface, so that there is a mthod for alloy generated bindings when the trait is in scope.

Solution

Add the trait and impl for the T: SolInterface

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs

@rouzwelt rouzwelt added the enhancement New feature or request label Jun 17, 2024
@rouzwelt rouzwelt self-assigned this Jun 17, 2024
@hardyjosh hardyjosh self-requested a review June 18, 2024 10:16
Copy link
Contributor

@hardyjosh hardyjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rouzwelt please make the error an enum with thiserror:Error derived on it. we can remove anyhow and use the standard Result

@rouzwelt rouzwelt requested a review from hardyjosh June 19, 2024 00:52
@rouzwelt
Copy link
Collaborator Author

@rouzwelt please make the error an enum with thiserror:Error derived on it. we can remove anyhow and use the standard Result

applied

Cargo.toml Outdated Show resolved Hide resolved
@rouzwelt rouzwelt requested a review from hardyjosh June 19, 2024 18:38
@hardyjosh hardyjosh merged commit f857ce5 into main Jun 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants