-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency on bootstrap-rails gem is too version-specific #1716
Comments
+1 on this issue. Can we statically include bootstrap 2 css files for now? |
I implement an fork branch. The dependency for bootstrap is removed and bootstrap-sass is statically included. gem "rails_admin", git: "[email protected]:bulleric/rails_admin.git", branch: "bootstrap2-dependency-patch" |
@bulleric If used with boostrap-sass 3 via gem 'bootstrap-sass', :git => 'git://github.com/thomas-mcdonald/bootstrap-sass.git', :branch => '3' Bootstrap 2 overrides Bootstrap 3 when assets are precompiled. |
@bulleric Can we submit a pull request with your fork? Why can't we statically include bootstrap inside of just the rails_admin template side? There has to be some kind of hook so your main app and this app both have different styles. |
Ah big sry it was my fault... I include statically the bootstrap files directly in
I think rails_admin only need the bootstrap directory because rails_admin.scss.erb doesn't include other files. --> #1733 |
Yeah, need a solution for Rails 3.2.x and bootstrap-sass 3 |
Why is this such a difficult problem to resolve? I have installed bootstrap-sass, pointing to the GH repo but not a branch, and yet bundle install still fails with this error: Resolving dependencies...
|
still need a solution for Rails 3.2 and bootstrap-sass 3 |
+1 |
3 similar comments
+1 |
+1 |
+1 |
+1000 |
To anyone else watching this ticket, this issue was fixed in master by #1799. |
Already fixed by #1799. |
Any hope of seeing this in the |
+1, I'm using rails 3 and want to use bootstrap-sass 3.x but rails_admin requires bootstrap-sass 2.x. |
for those who are looking for a way to use rails 3 + bs3 + rails_admin, try #1799 (comment) |
Keeping sync between the two gems is too difficult; right now, for instance, one cannot update to the Bootstrap 3 branch of that gem because of RailsAdmin's need for bootstrap-sass (~> 2.3) when to use the other I need to specify :git => 'git://github.com/thomas-mcdonald/bootstrap-sass.git', :branch => '3'.
The text was updated successfully, but these errors were encountered: