Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on bootstrap-rails gem is too version-specific #1716

Closed
billsaysthis opened this issue Aug 18, 2013 · 18 comments
Closed

Dependency on bootstrap-rails gem is too version-specific #1716

billsaysthis opened this issue Aug 18, 2013 · 18 comments

Comments

@billsaysthis
Copy link

Keeping sync between the two gems is too difficult; right now, for instance, one cannot update to the Bootstrap 3 branch of that gem because of RailsAdmin's need for bootstrap-sass (~> 2.3) when to use the other I need to specify :git => 'git://github.com/thomas-mcdonald/bootstrap-sass.git', :branch => '3'.

@drubin drubin mentioned this issue Aug 20, 2013
@AlJohri
Copy link

AlJohri commented Aug 20, 2013

+1 on this issue. Can we statically include bootstrap 2 css files for now?

@bulleric
Copy link

I implement an fork branch. The dependency for bootstrap is removed and bootstrap-sass is statically included.

gem "rails_admin", git: "[email protected]:bulleric/rails_admin.git", branch: "bootstrap2-dependency-patch"

@AlJohri
Copy link

AlJohri commented Aug 27, 2013

@bulleric If used with boostrap-sass 3 via

gem 'bootstrap-sass', :git => 'git://github.com/thomas-mcdonald/bootstrap-sass.git', :branch => '3'

Bootstrap 2 overrides Bootstrap 3 when assets are precompiled.

@allenwyma
Copy link

@bulleric Can we submit a pull request with your fork? Why can't we statically include bootstrap inside of just the rails_admin template side? There has to be some kind of hook so your main app and this app both have different styles.

@bulleric
Copy link

bulleric commented Sep 3, 2013

Ah big sry it was my fault... I include statically the bootstrap files directly in
assets/styleesheets/

  • bootstrap.css
  • bootstrap.min.css
  • bootstrap-response.css
  • bootstrap-responsive.min.css
  • bootstrap ( directory)
    In other respects every application wich mount rails_admin will load this static bootstrap files.
    Now i remove all files excepting the bootstrap directory, i rename the bootstrap directory to bootstrap2 and adjust all bootstrap includes in assets/stylesheets/rails_admin/rails_admin.scss.erb

I think rails_admin only need the bootstrap directory because rails_admin.scss.erb doesn't include other files.
I think my branch is now stable with that patch and bootstrap3 can be used in an application with rails_admin
I submit an pull request to the rails_admin master.

--> #1733

@mikepence
Copy link

Yeah, need a solution for Rails 3.2.x and bootstrap-sass 3

@billsaysthis
Copy link
Author

Why is this such a difficult problem to resolve? I have installed bootstrap-sass, pointing to the GH repo but not a branch, and yet bundle install still fails with this error:

Resolving dependencies...
Bundler could not find compatible versions for gem "bootstrap-sass":
In Gemfile:
rails_admin (>= 0) ruby depends on
bootstrap-sass (~> 2.0) ruby

bootstrap-sass (3.0.0.0)

@mastermike14
Copy link

still need a solution for Rails 3.2 and bootstrap-sass 3

@mikepence
Copy link

+1

3 similar comments
@JFickel
Copy link

JFickel commented Oct 28, 2013

+1

@mahemoff
Copy link

+1

@roneesh
Copy link

roneesh commented Nov 8, 2013

+1

@zaccherinij
Copy link

+1000

@dmdeller
Copy link

To anyone else watching this ticket, this issue was fixed in master by #1799.

@mshibuya
Copy link
Member

Already fixed by #1799.

@troy
Copy link

troy commented Nov 26, 2013

Any hope of seeing this in the rails-3.x branch, a 0.4.10 release, or another way of using it with Rails 3.x? The gemspec in master requires rails 4.

@hamxiaoz
Copy link

hamxiaoz commented Dec 5, 2013

+1, I'm using rails 3 and want to use bootstrap-sass 3.x but rails_admin requires bootstrap-sass 2.x.
The fixed rails_admin requires rails 4 however.

@amseledka
Copy link

for those who are looking for a way to use rails 3 + bs3 + rails_admin, try #1799 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests